Upgraded tidb parser version for vulnerability fixes.#1346
Open
pratickchokhani wants to merge 1 commit into
Open
Upgraded tidb parser version for vulnerability fixes.#1346pratickchokhani wants to merge 1 commit into
pratickchokhani wants to merge 1 commit into
Conversation
pratickchokhani
requested review from
darshan-sj and
shreyakhajanchi
and removed request for
a team
pratickchokhani
force-pushed
the
tidb-vul-fix
branch
2 times, most recently
from
2d82cf5 to
c1fb222
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1346 +/- ##
=======================================
Coverage 51.19% 51.19%
=======================================
Files 202 202
Lines 22796 22796
Branches 552 552
=======================================
Hits 11671 11671
Misses 10437 10437
Partials 688 688
🚀 New features to boost your workflow:
|
VardhanThigle
approved these changes
May 27, 2026
pratickchokhani
force-pushed
the
tidb-vul-fix
branch
from
c1fb222 to
4c52aaf
Compare
manitgupta
reviewed
May 27, 2026
Comment on lines
-26
to
-27
| github.com/pingcap/tidb v1.1.0-beta.0.20251126154744-e4e814fdc0af | ||
| github.com/pingcap/tidb/pkg/parser v0.0.0-20251126154744-e4e814fdc0af |
Member
There was a problem hiding this comment.
We moved from a newer version to an older version? 202511 -> 202407? How does that fix things?
Can you please update the description with details on what we did and how we have tested that it works?
Contributor
Author
There was a problem hiding this comment.
The release version with TIDB is non-linear. Earlier I choose a latest release as the CVE note shows that the fix was added in May.
With this, I am choosing the specific release mentioned in the CVE note.
| github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping v0.53.0 // indirect | ||
| github.com/VividCortex/ewma v1.2.0 // indirect | ||
| github.com/cloudfoundry/gosigar v1.3.6 // indirect | ||
| github.com/cockroachdb/errors v1.11.1 // indirect |
Contributor
There was a problem hiding this comment.
why is there a dependency on cockroach ?
Contributor
Author
There was a problem hiding this comment.
This is coming form TIDB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.